fix(stdlib): do not load some tests #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
requested review from
skartikey and
onelson
and removed request for
a team and
skartikey
Some tests that should error have a different error message when pushed down. This is fine and make sense. To keep things simple this change no longer uses testing.load for those tests. Equivalent tests will be added to InfluxDB directly to ensure we still get those different errors.
nathanielc
force-pushed
the
fix/influxdb-pushdown-tests
branch
from
e8f0792
to
117fbee
Compare
onelson
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Seems fine. Ideally we'd enhance shouldError such that we can indicate a portion of the string can be ignored, or otherwise uses a regex matcher. I don't think the line/column numbers are a great signal for anything in this situation.
Python doc tests use an ellipsis to say a portion of a pattern matches anything, but the remaining portions are used verbatim. Probably that's more than we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests that should error have a different error message when pushed
down. This is fine and make sense. To keep things simple this change no
longer uses testing.load for those tests. Equivalent tests will be added
to InfluxDB directly to ensure we still get those different errors.
Done checklist