fix(stdlib): generate placeholder.go file when needed #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
requested review from
Rahul-Vasan,
noramullen1,
scbrickley and
a team
and removed request for
a team
nathanielc
force-pushed
the
fix/stdlib-generate
branch
from
0284ef3
to
3492fb2
Compare
scbrickley
approved these changes
Jul 1, 2022
Go's vendoring semantics mean we need all Flux packages to also be Go packages. This change handles that logic. This is similar to the flux_gen.go solution we had previously, but different in one key way. The contents of placeholder.go are static. This means we do not need to treat them as special binary files or otherwise. Additionally the new name of placeholder.go is clear what its purpose is.
nathanielc
force-pushed
the
fix/stdlib-generate
branch
from
3492fb2
to
0b70ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's vendoring semantics mean we need all Flux packages to also be Go
packages. This change handles that logic. This is similar to the
flux_gen.go solution we had previously, but different in one key way.
The contents of placeholder.go are static. This means we do not need to
treat them as special binary files or otherwise. Additionally the new
name of placeholder.go is clear what its purpose is.
Finally a test to
cmd/flux/for test extension was added as that is how this was discovered.Done checklist