feat: allow physical plan attributes to contribute to formatter details #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-thurston
force-pushed
the
feat/physical-attribute-plan-details
branch
from
9d82d4c
to
1f7d0bd
Compare
In order to determine if a query plan has been parallelized we have been using the presence of a partitionMerge node in the plan. With the emergence of a new technique of merging in aggregateWindow nodes, and possibly soon pivot nodes as well, we can no longer use this test. This PR allows physical plan attributes to contribute to plan details. First the spec is consulted, then any physical attributes that are present. Any node with the parallel merge attribute can then indicate it is a merge node.
onelson
approved these changes
Jul 1, 2022
|
@onelson I saw you asked this question and it never got answered. We put the plan into the profile if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to determine if a query plan has been parallelized, we have been using
the presence of a
partitionMergenode in the plan. With the emergence of a newtechnique of merging in
aggregateWindownodes, and possibly soonpivotnodes aswell, we can no longer use this test.
This PR allows physical plan attributes to contribute to plan details. First
the spec is consulted, then any physical attributes that are present. Any node
with the
ParallelMergeattribute can then indicate it is a merge node.Done checklist