Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): deprecate experimental.csv #4922

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

nathanielc
Copy link
Contributor

experimental.csv only provides a simple way to query a URL and parse
as CSV, now that requests package is complete its best to use and
compose this logic as needed. As it stands experimental.csv can't
check the HTTP status code and so its best this is left to the developer
writing the code.

Depends on #4921 merging first.

Done checklist

  • docs/SPEC.md updated
  • Test cases written

`experimental.csv` only provides a simple way to query a URL and parse
as CSV, now that `requests` package is complete its best to use and
compose this logic as needed. As it stands `experimental.csv` can't
check the HTTP status code and so its best this is left to the developer
writing the code.
@nathanielc nathanielc marked this pull request as ready for review June 27, 2022 18:34
@nathanielc nathanielc requested review from a team as code owners June 27, 2022 18:34
@nathanielc nathanielc requested review from Rahul-Vasan, jstirnaman and onelson and removed request for a team June 27, 2022 18:34
Copy link
Contributor

@onelson onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielc nathanielc merged commit 0439182 into master Jun 27, 2022
@jacobmarble jacobmarble deleted the feat/deprecate-exp-csv branch January 4, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants