fix(table_fns): make findColumn() able to handle multi-buffer tables #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolffcm
requested review from
OfTheDelmer and
noramullen1
and removed request for
a team
sanderson
approved these changes
Jun 16, 2022
OfTheDelmer
approved these changes
Jun 17, 2022
| has40: true, | ||
| } | ||
| got = array.from(rows: [{value: display(v: gotObj)}]) | ||
| want = array.from(rows: [{value: display(v: wantObj)}]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
findColumnwas not dealing with tables with multiple buffers, and each subsequent buffer would overwrite the answer for the previous. This PR addresses that and adds some more tests.Fixes #4884.
Done checklist