feat: Add a pretty.rs based MonoType formatter #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fmt::Display` based formatter only included absolutely necessary whitespace which creates compact output which is rather hard to read. By copying over the formatter used for `ast::MonoType` we get more readable output in error messages and the LSP.
added 2 commits
May 31, 2022 18:32
Ensures that we always go through the pretty.rs implementation. (I checked flux-lsp and the only brekage is in a test due to the addition of whitespace). BREAKING CHANGE Some `std::fmt::Display` implementations have been removed in the `types` module. Convert to `MonoType` and use its `Display` implementation instead or write the formatting manually.
skartikey
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fmt::Displaybased formatter only included absolutely necessary whitespace whichcreates compact output which is rather hard to read. By copying over the formatter used for
ast::MonoTypewe get more readable output in error messages and the LSP.(I checked flux-lsp and the only brekage is in a test due to the addition of whitespace).
BREAKING CHANGE
Some
std::fmt::Displayimplementations have been removed in thetypesmodule. Convert toMonoTypeand use itsDisplayimplementation instead or write the formatting manually.