fix: Make it an error to use a label variable without the Label constraint #4788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2022
OfTheDelmer
approved these changes
Jun 6, 2022
added 2 commits
June 7, 2022 11:48
…raint Forgetting to add the `Label` constraint leads to confusing typechecking failures down the line as it becomes possible to pass non-labels and string literals ends up treated as strings instead of labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgetting to add the
Labelconstraint leads to confusing typechecking failures down the line asit becomes possible to pass non-labels and string literals ends up treated as strings instead of labels.