Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semantic): attach type when constructing logical expressions #4783

Merged
merged 1 commit into from
May 23, 2022
Merged

fix(semantic): attach type when constructing logical expressions #4783

merged 1 commit into from
May 23, 2022

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented May 23, 2022 •
edited
Loading

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@jsternberg jsternberg requested a review from a team as a code owner May 23, 2022 21:04
@jsternberg jsternberg requested review from onelson and removed request for a team May 23, 2022 21:04
@nathanielc nathanielc force-pushed the fix/semantic-rewrite-logical-type branch from e884123 to 663b3c9 Compare May 23, 2022 21:47
onelson
onelson approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@onelson onelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

iirc this relates back to how we handle these expressions while vectorizing. Perhaps this just means we can substitute the typing to the base case of bool instead of having to additionally support the expr type. Am I thinking about this right?

@nathanielc nathanielc merged commit 773519e into master May 23, 2022
@nathanielc nathanielc deleted the fix/semantic-rewrite-logical-type branch May 23, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onelson onelson onelson approved these changes

@nathanielc nathanielc nathanielc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsternberg @onelson @nathanielc