feat(date): add location support to date.truncate function #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
requested review from
Marwes and
sunbryely-influxdata
and removed request for
a team
|
CC @skartikey |
2opremio
force-pushed
the
4656-truncate-location-support
branch
from
5cf4ff7
to
5c3affa
Compare
Marwes
suggested changes
Apr 19, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| b := w.GetLatestBounds(t) |
There was a problem hiding this comment.
Strange how we have two "Window" types and one supports GetEarliestBounds and the other only supports GetLatestBounds. Since the windows do not overlap they ought to return the same result either way at least (nothing to change here).
There was a problem hiding this comment.
Agreed! BTW execute.Window seems to only be used by interpolate. So I think may be able to get rid of it and completely replace it by interval.Window.
|
@Marwes PTAL! |
|
@Marwes friendly ping |
Marwes
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execute.Windowbyinterval.WindowInspired by #4327
fixes #4656
Done checklist