Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): add trace option to the flux cli #4674

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Apr 14, 2022

Done checklist

  • docs/SPEC.md updated
  • Test cases written

@jsternberg jsternberg requested a review from a team as a code owner April 14, 2022 20:59
@jsternberg jsternberg requested review from nathanielc and removed request for a team April 14, 2022 20:59
Copy link
Contributor

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you use this? Looks like you need your local env to be configured to point to a jaeger install? Is the intent that it would be an existing production install? Or one inside the isolation testing env?

Does adding a trace client side associate the trace with the server side trace/spans?

@jsternberg
Copy link
Contributor Author

It's mostly meant to be used with a local jaeger. You run the jaeger docker image and then just use --trace and it will upload it to your local one on localhost. Since this is the CLI, there are no server side trace/spans. It's just taking the existing opentracing infrastructure and allowing it to be used from the CLI.

It was originally removed when we removed the opentracing components. Then @wolffcm added better designed ones in and this became useful again.

@wolffcm
Copy link

wolffcm commented Apr 14, 2022

Can we include quick instructions (or a link) somewhere on how to set up a local Jaeger? I can see this being useful.

@onelson
Copy link
Contributor

onelson commented Apr 14, 2022

@jsternberg jsternberg merged commit c9dec75 into master Apr 19, 2022
@jsternberg jsternberg deleted the feat/cli-trace-option branch April 19, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants