fix: restore required features hidden behind cffi #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstar
force-pushed
the
fix/adjust-aggressive-cffi-feature
branch
2 times, most recently
from
6179efa
to
4405098
Compare
In my haste to merge the `cffi` feature, I was too aggressive in what needed to move behind the flag. This broke my work in `flux-lsp`, which doesn't use the `cffi` feature. This patch restores what shouldn't be behind a feature flag.
rockstar
force-pushed
the
fix/adjust-aggressive-cffi-feature
branch
from
4405098
to
3933d27
Compare
skartikey
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my haste to merge the
cffifeature, I was too aggressive in whatneeded to move behind the flag. This broke my work in
flux-lsp, whichdoesn't use the
cffifeature. This patch restores what shouldn't bebehind a feature flag.