Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create better error message for pivot column conflict #4579

Merged
merged 1 commit into from
Apr 4, 2022
Merged

fix: create better error message for pivot column conflict #4579

merged 1 commit into from
Apr 4, 2022

Conversation

wolffcm
Copy link

@wolffcm wolffcm commented Mar 21, 2022

This PR creates a more informative error message when a call to pivot() would require creating a column that already exists.

Also, the type of the error has been changed to invalid so it is seen by users.

fix: create better error message for pivot column conflict
4a05b01 
Also, change the type of the error to Invalid so it is seen by users.
@wolffcm wolffcm requested a review from a team as a code owner March 21, 2022 22:26
@wolffcm wolffcm requested review from jsternberg and removed request for a team March 21, 2022 22:26
@wolffcm wolffcm merged commit e2648ea into master Apr 4, 2022
@wolffcm wolffcm deleted the fix/pivot-err branch April 4, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsternberg jsternberg jsternberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolffcm @jsternberg