fix(formatter): fix testcase format to not hang too much #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
requested review from
skartikey and
sunbryely-influxdata
and removed request for
a team
nathanielc
force-pushed
the
fix/testcase-comment
branch
from
c663fda
to
0333115
Compare
sunbryely-influxdata
approved these changes
Mar 17, 2022
nathanielc
force-pushed
the
fix/testcase-comment
branch
from
0333115
to
50823d3
Compare
Prior to this change a comment before a testcase statement would cause
the formatter to hang the `{` on a new line and unnecessarily nest the
body of the testcase.
nathanielc
force-pushed
the
fix/testcase-comment
branch
from
50823d3
to
25a1028
Compare
skartikey
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change a comment before a testcase statement would cause
the formatter to hang the
{on a new line and unnecessarily nest thebody of the testcase.
Done checklist