fix: skip parallel merge nodes when selecting the result name #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… effects If a node is a parallel merge then it was added by the planner and might be a successor of a node with side effects. In order to preserve behaviour, skip these parallel merge nodes and check if the predecessor has side effects. If so, use that node name instead.
onelson
approved these changes
Mar 16, 2022
| // of a side-effect result; skip them. | ||
| if isParallelMerge { | ||
| if len( node.Predecessors() ) != 1 { | ||
| return "", errors.New(codes.Internal, "parallel merge must have a single predecessor") |
There was a problem hiding this comment.
I think you mentioned possibly being able to enforce this during planning. The check here should probably be here regardless, but I'm wondering if there'll be a follow-on to this follow-on.
There was a problem hiding this comment.
Yes, was planning on adding to the planner attributes a way to say that the node with the attribute must have at least one successor, or that it must have at least one predecessor.
adrian-thurston
force-pushed
the
fix/skip-merge-result-name
branch
from
cff4b14
to
e100e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node is a parallel merge then it was added by the planner and might be a
successor of a node with side effects. In order to preserve behaviour, skip
these parallel merge nodes and check if the predecessor has side effects. If
so, use that node name instead.
Done checklist