feat(mqtt): enable dialer pool for everyone #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had implemented a way to allow flux to reuse client connections to mqtt across calls to `mqtt.publish`, but it was hidden behind a feature flag pending verification of the new behavior. After some manual testing, things appear to be in good shape. By inspecting a mosquitto mqtt broker's server log, and toggling the flag off/on, we could see that when the feature is enabled there's a single client connection and serveral publishes (versus one connection per publish when the flag is off). This diff removes the feature flag, turning the new code path on for everyone.
|
@samhld Once this merges and with the next Flux release(next week) the mqtt work will be live for everyone |
rockstar
approved these changes
Mar 16, 2022
jsternberg
added a commit
that referenced
this pull request
Mar 22, 2022
This reverts commit dc08c57.
jsternberg
added a commit
that referenced
this pull request
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had implemented a way to allow flux to reuse client
connections to mqtt across calls to
mqtt.publish, but it was hiddenbehind a feature flag pending verification of the new behavior.
After some manual testing, things appear to be in good shape. By
inspecting a mosquitto mqtt broker's server log, and toggling the flag
off/on, we could see that when the feature is enabled there's a single
client connection and serveral publishes (versus one connection per
publish when the flag is off).
This diff removes the feature flag, turning the new code path on for
everyone.
Done checklist