Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add an IOx specific unpivot #4553

Merged
merged 4 commits into from
Mar 16, 2022
Merged

feat: Add an IOx specific unpivot #4553

merged 4 commits into from
Mar 16, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Mar 11, 2022

We need Flux queries with IOx to work over the SQL endpoint and produce unpivoted data. This is so we can rewrite this query to be backed by IOx:

from()
   |> range()
   |> filter()
   |> group()
   |> mean()

The plan would look something like:

IOx SQL Source -> Unpivot -> Mean

Closes #4529

Done checklist

  • Test cases written

@Marwes Marwes requested review from a team as code owners March 11, 2022 12:54
@Marwes Marwes requested review from skartikey and noramullen1 and removed request for a team March 11, 2022 12:54
@sanderson sanderson requested review from sanderson and removed request for noramullen1 March 11, 2022 16:27
sanderson
sanderson approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a doc suggestion, but I'll go ahead and approve this 👍🏻

stdlib/internal/debug/debug.flux Outdated Show resolved Hide resolved
skartikey
skartikey approved these changes Mar 14, 2022
View reviewed changes
stdlib/internal/debug/unpivot.go Outdated
}

for i, c := range chunk.Cols() {
// for i := len(chunk.Cols()) - 1; i >= 0; i-- {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like commented code was left by mistake here.

Markus Westerlind and others added 2 commits March 16, 2022 12:48
@Marwes Marwes merged commit 1d88679 into master Mar 16, 2022
@Marwes Marwes deleted the issue_4529 branch March 16, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderson sanderson sanderson approved these changes

@skartikey skartikey skartikey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IOx specific unpivot
3 participants
@Marwes @sanderson @skartikey