Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Generalize Substitutable::apply_ref #4499

Merged
merged 5 commits into from
Mar 29, 2022
Merged

refactor: Generalize Substitutable::apply_ref #4499

merged 5 commits into from
Mar 29, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Feb 18, 2022

Makes apply_ref a proper visitor. Substituter is kept (but should perhaps be renamed) and is extended with additional methods that allow the specific Substututer to inject logic for PolyType. Through this we can implement max_tvar and free_vars in terms of the same visit method as apply.

Extracted from #4388

@Marwes Marwes requested a review from a team as a code owner February 18, 2022 15:03
@Marwes Marwes requested review from jsternberg and removed request for a team February 18, 2022 15:03
@Marwes
Copy link
Contributor Author

Marwes commented Mar 29, 2022

ping @jsternberg

@Marwes Marwes merged commit e031aa0 into master Mar 29, 2022
@Marwes Marwes deleted the type_visitor_2 branch March 29, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsternberg jsternberg jsternberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marwes @jsternberg