Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rust to 1.58 #4406

Merged
merged 3 commits into from
Jan 19, 2022
Merged

chore: Update rust to 1.58 #4406

merged 3 commits into from
Jan 19, 2022

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 14, 2022

No description provided.

@Marwes Marwes requested a review from a team as a code owner January 14, 2022 16:20
@Marwes Marwes requested review from skartikey and removed request for a team January 14, 2022 16:20
@Marwes Marwes force-pushed the update_Rust branch 3 times, most recently from 1f9ff62 to cb8637d Compare January 17, 2022 11:07
Marwes pushed a commit to influxdata/pkg-config that referenced this pull request Jan 17, 2022
Due to rust-lang/rust#84096 we need to link to bcrypt on windows else we get linker errors.

cc influxdata/flux#4406

https://app.circleci.com/pipelines/github/influxdata/flux/11766/workflows/d1ef0c61-babb-4682-8c74-7087013c873e/jobs/38341

```
C:\\Users\\circleci\\AppData\\Local\\go-build\\pkgconfig\\windows_amd64\\lib/libflux-3dd4b4346280d5a830d03b58d109be24cf44fd0ab5964e0113b470e7ba1223ed.a(std-c90c2a9f63fc5684.std.04e7289e-cgu.0.rcgu.o): In function `std::sys::windows::rand::hashmap_random_keys':
/rustc/02072b482a8b5357f7fb5e5637444ae30e423c40\/library\std\src\sys\windows/rand.rs:10: undefined reference to `BCryptGenRandom'
/rustc/02072b482a8b5357f7fb5e5637444ae30e423c40\/library\std\src\sys\windows/rand.rs:10: undefined reference to `BCryptGenRandom'
collect2.exe: error: ld returned 1 exit status

Exited with code exit status 2

```
@Marwes Marwes merged commit 11d6127 into master Jan 19, 2022
@Marwes Marwes deleted the update_Rust branch January 19, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants