Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg/Template restructure #1091

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Pkg/Template restructure #1091

merged 5 commits into from
Jun 9, 2020

Conversation

sanderson
Copy link
Collaborator

Closes #1087
Closes #1088

  • Tests pass (no build errors)
  • Rebased/mergeable

content/v2.0/influxdb-templates/use.md Show resolved Hide resolved
content/v2.0/reference/cli/influx/apply/_index.md Outdated Show resolved Hide resolved
content/v2.0/reference/cli/influx/export/all.md Outdated Show resolved Hide resolved
content/v2.0/reference/cli/influx/export/all.md Outdated Show resolved Hide resolved
Comment on lines +21 to +22
influx stacks [flags]
influx stacks [command]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flags after subcommands? global

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the CLI itself outputs the usage and is the same throughout the CLI docs. I think the argument is that using flags is more common than using subcommands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question, I'm not sure why the output is like that. It is generated by the library we use to create the CLI 🤔

content/v2.0/reference/cli/influx/stacks/init.md Outdated Show resolved Hide resolved
content/v2.0/reference/cli/influx/stacks/remove.md Outdated Show resolved Hide resolved
content/v2.0/reference/cli/influx/template/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @kelseiv!

content/v2.0/reference/cli/influx/export/all.md Outdated Show resolved Hide resolved
Comment on lines +21 to +22
influx stacks [flags]
influx stacks [command]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the CLI itself outputs the usage and is the same throughout the CLI docs. I think the argument is that using flags is more common than using subcommands.

@sanderson sanderson requested a review from jsteenb2 June 9, 2020 17:49
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@sanderson sanderson merged commit 99df2d3 into beta-12 Jun 9, 2020
@sanderson sanderson deleted the pkg-restructure branch June 9, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants