Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support InfluxDB behind proxy under subpath #5940

Merged
merged 12 commits into from
Jun 20, 2022

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Jun 15, 2022

Closes #5096

Briefly describe your proposed changes:
This PR changes the communication with InfluxDB so that a configured InfluxDB connection URL path is preserved as a context path when calling InfluxDB APIs. It works fine with InfluxDB OSS. InfluxDB Enterprise connections still must be configured without a context path (a proxy path), the cluster design requires doing so.

What was the problem?
InfluxDB Connection URL context path was ignored, and paths of InfluxDB APIs were directly used.

What was the solution?
API paths are appended to the configured InfluxDB connection path.

@sranka sranka changed the title feat(server): add support for InfluxDB behind proxy under subpath feat(server): support InfluxDB behind proxy under subpath Jun 16, 2022
@sranka sranka force-pushed the 5096/influxdb_context_path branch from 3cc72d6 to 85db81a Compare June 16, 2022 06:13
@sranka sranka marked this pull request as ready for review June 16, 2022 06:16
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sranka sranka merged commit 4723e46 into master Jun 20, 2022
@sranka sranka deleted the 5096/influxdb_context_path branch June 20, 2022 08:58
@sranka sranka added this to the 1.10 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for InfluxDB behind reverse proxy under subpath (https://example.com/influxdb/)
2 participants