Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(iox-11398): patched df upgrade 2024-07-02 #31

Closed
wants to merge 3 commits into from

Conversation

appletreeisyellow
Copy link

@appletreeisyellow appletreeisyellow commented Jul 11, 2024

⚠️ This will not be merged. ⚠️

  1. Bringing us up to datafusion to 2024-07-02, apache@3421b52

  2. This PR is based on 2024-06-30 apache@a64df83

    git co -b chunchun/update-df-july-week-1 a64df83502821f18067fb4ff65dd217815b305c9
    
  3. Cherry-picked the following commits:

    1. fix: Incorrect LEFT JOIN evaluation result on OR conditions apache/datafusion#11203 / apache@03c8db0

      commit 03c8db0a988f75446719bf77535076854c97b220
      Author: Liang-Chi Hsieh <[email protected]>
      Date:   Wed Jul 3 08:01:26 2024 -0700
      
           fix: Incorrect LEFT JOIN evaluation result on OR conditions (#11203)
    2. feat: add UDF to_local_time() apache/datafusion#11347 / apache@f284e3b

      commit f284e3bb73e089abc0c06b3314014522411bf1da
      Author: Chunchun Ye <[email protected]>
      Date:   Thu Jul 11 11:17:09 2024 -0500
      
          feat: add UDF to_local_time() (#11347)

appletreeisyellow and others added 2 commits July 11, 2024 16:27
* feat: add UDF `to_local_time()`

* chore: support column value in array

* chore: lint

* chore: fix conversion for us, ms, and s

* chore: add more tests for daylight savings time

* chore: add function description

* refactor: update tests and add examples in description

* chore: add description and example

* chore: doc

chore: doc

chore: doc

chore: doc

chore: doc

* chore: stop copying

* chore: fix typo

* chore: mention that the offset varies based on daylight savings time

* refactor: parse timezone once and update examples in description

* refactor: replace map..concat with flat_map

* chore: add hard code timestamp value in test

chore: doc

chore: doc

* chore: handle errors and remove panics

* chore: move some test to slt

* chore: clone time_value

* chore: typo

---------

Co-authored-by: Andrew Lamb <[email protected]>
…1203)

* fix: Incorrect LEFT JOIN evaluation result on OR conditions

* Add a few more test cases

* Don't push join filter predicates into join_conditions

* Add test case and fix typo

* Add test case

---------

Co-authored-by: Andrew Lamb <[email protected]>
@appletreeisyellow
Copy link
Author

Closing because the upgrade is done

@appletreeisyellow appletreeisyellow deleted the chunchun/update-df-july-week-1 branch July 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants