Implement $set stage dsl #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
username1103
commented
Oct 29, 2023
Comment on lines
118
to
131
| /** | ||
| * @see <a href="https://www.mongodb.com/docs/manual/reference/operator/aggregation/set/#add-element-to-an-array">Add Element to an Array</a> | ||
| */ | ||
| fun addElementToAnArray(): AggregationResults<Score> { | ||
| val aggregation = aggregation { | ||
| match(Criteria.where(Score::id.toDotPath()).isEqualTo(1)) | ||
| set { | ||
| // TODO: add $concatArrays expression | ||
| Score::homework set Document("\$concatArrays", listOf("\$${Score::homework.toDotPath()}", listOf(7))) | ||
| } | ||
| } | ||
|
|
||
| return mongoTemplate.aggregate<Score>(aggregation, SCORES) | ||
| } |
There was a problem hiding this comment.
In example, we have to add 7 at the end of "homework" array.
db.scores.aggregate([
{ $match: { _id: 1 } },
{ $set: { homework: { $concatArrays: [ "$homework", [ 7 ] ] } } }
])
But, ConcatArrays not supported this. We can only concat value at the beginning maybe..
There was a problem hiding this comment.
how about using literal expression. literals(listof(7))
but I can not sure if it works
There was a problem hiding this comment.
👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻👍🏻 it work well.
There was a problem hiding this comment.
Hmm, I think it is better to implement $concatArrays without using ArrayOperator from spring.
It seems fine to leave it as it for now :)
username1103
force-pushed
the
set-stage-dsl
branch
from
8d91d06
to
80c6c4b
Compare
jbl428
reviewed
Oct 29, 2023
Comment on lines
+27
to
+29
| set { | ||
| SalesDto::id set "2017" | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #72