Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SafeBuffer support (up to 6.1.0) #318

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Add SafeBuffer support (up to 6.1.0) #318

merged 4 commits into from
Sep 5, 2024

Conversation

DmitryAstafyev
Copy link
Contributor

@DmitryAstafyev DmitryAstafyev commented Sep 5, 2024 •
edited
Loading

Reason

No way to use ArrayBuffer in context of electron

Subject

Adds supporting of SafeBuffer. Unfortunately electron has restrictions to use ArrayBuffer as a workaround can be used SafeBuffer.

Realations

@DmitryAstafyev DmitryAstafyev mentioned this pull request Sep 5, 2024
Closed
@DmitryAstafyev DmitryAstafyev changed the title Add UInt8Array support (up to 6.0.3) Add SafeBuffer support (up to 6.0.3) Sep 5, 2024
@morenol morenol requested a review from sehz September 5, 2024 14:04
sehz
sehz requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A small nit on version number

Cargo.toml Outdated Show resolved Hide resolved
@sehz
Copy link
Collaborator

sehz commented Sep 5, 2024

Oh. You hit the jackpot, It's rust update date today. Can you create another PR to update clipping rules? Thanks

@DmitryAstafyev
Copy link
Contributor Author

Some clippy errors, will fix and include

@DmitryAstafyev
Copy link
Contributor Author

@sehz done

@DmitryAstafyev DmitryAstafyev changed the title Add SafeBuffer support (up to 6.0.3) Add SafeBuffer support (up to 6.1.0) Sep 5, 2024
sehz
sehz approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Great job

@sehz sehz added this pull request to the merge queue Sep 5, 2024
Merged via the queue into infinyon:master with commit 054fba4 Sep 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitryAstafyev @sehz