Issue-1473: App Crash with Invalid scriptURL

lib/reactotron-react-native/src/helpers/parseURL.test.ts

@@ -0,0 +1,59 @@
+import { getHostFromUrl } from "./parseURL"
+
+describe("getHostFromUrl", () => {
+  it("should throw when no host is found", () => {
+    expect(() => {
+      getHostFromUrl("")
+    }).toThrow()
+  })
+
+  it("should get host from URL without scheme", () => {
+    Object.entries({
+      localhost: "localhost",
+      "127.0.0.1": "127.0.0.1",
+    }).forEach(([host, url]) => {
+      expect(getHostFromUrl(url)).toEqual(host)
+    })
+    expect(getHostFromUrl("localhost")).toEqual("localhost")
+    expect(getHostFromUrl("127.0.0.1")).toEqual("127.0.0.1")
+  })
+
+  it("should get the host from URL with http scheme", () => {
+    Object.entries({
+      localhost: "http://localhost",
+      "example.com": "http://example.com",
+    }).forEach(([host, url]) => {
+      expect(getHostFromUrl(url)).toEqual(host)
+    })
+  })
+
+  it("should get the host from URL with https scheme", () => {
+    Object.entries({
+      localhost: "https://localhost",
+      "example.com": "https://example.com",
+    }).forEach(([host, url]) => {
+      expect(getHostFromUrl(url)).toEqual(host)
+    })
+  })
+
+  it("should get the host from URL and ignore path, port, and query params", () => {
+    Object.entries({
+      localhost:
+        "http://localhost:8081/.expo/.virtual-metro-entry.bundle?platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=com.reactotronapp",
+      "192.168.1.141":
+        "https://192.168.1.141:8081/.expo/.virtual-metro-entry.bundle?platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=com.reactotronapp",
+    }).forEach(([host, url]) => {
+      expect(getHostFromUrl(url)).toEqual(host)
+    })
+  })
+
+  it("should get the host from URL with hyphens", () => {
+    expect(getHostFromUrl("https://example-app.com")).toEqual("example-app.com")
+  })
+
+  it("should throw when the URL is an unsupported scheme", () => {
+    expect(() => {
+      getHostFromUrl("file:///Users/tron")
+    }).toThrow()
+  })
+})

lib/reactotron-react-native/src/helpers/parseURL.ts

@@ -0,0 +1,19 @@
+/**
+ * Given a valid http(s) URL, the host for the given URL
+ * is returned.
+ *
+ * @param url {string} URL to extract the host from
+ * @returns {string} host of given URL or throws
+ */
+// Using a capture group to extract the hostname from a URL
+export function getHostFromUrl(url: string) {
+  // Group 1: http(s)://
+  // Group 2: host
+  // Group 3: port
+  // Group 4: rest
+  const host = url.match(/^(?:https?:\/\/)?([^/:\s]+)(?::\d+)?(?:[/?#]|$)/)?.[1]
+
+  if (typeof host !== "string") throw new Error("Invalid URL - host not found")
+
+  return host
+}

lib/reactotron-react-native/src/reactotron-react-native.ts

@@ -19,6 +19,7 @@ import networking, { NetworkingOptions } from "./plugins/networking"
 import storybook from "./plugins/storybook"
 import devTools from "./plugins/devTools"
 import trackGlobalLogs from "./plugins/trackGlobalLogs"
+import { getHostFromUrl } from "./helpers/parseURL"
 
 const constants = NativeModules.PlatformConstants || {}
 
@@ -39,12 +40,7 @@ const getHost = (defaultHost = "localhost") => {
     const scriptURL = NativeModules?.SourceCode?.getConstants().scriptURL
     if (typeof scriptURL !== "string") throw new Error("Invalid non-string URL")
 
-    // Using a capture group to extract the hostname from a URL
-    const host = scriptURL.match(/^(?:https?:\/\/)?([^/:\s]+)(?::\d+)?(?:[/?#]|$)/)?.[1]
-
-    if (typeof host !== "string") throw new Error("Invalid URL - host not found")
-
-    return host
+    return getHostFromUrl(scriptURL)
   } catch (error) {
     console.warn(`getHost: "${error.message}" for scriptURL - Falling back to ${defaultHost}`)
     return defaultHost