ESM related fixes #897
Merged
ESM related fixes #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onment-agnostic way
+ Added "type": "commonjs" explicitly.
Added ESM version of the model files using esbuild and import conditionally based on the environment.
+ Added buffer as peer dep.
…s with their weight files + Updated bundle-model.mjs to generate model files in esm and cjs directories. + Updated imports with new paths.
mazenchami
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
@haZya great work on this! thank you very much for putting the time into it. I'll be merging this and putting out a release soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #863, fixes #876
What does this PR do?
This fixes some issues related to ESM bundling.
Dynamic import cannot be analyzed by Vite. This could be fixed by using a plugin likevite-plugin-dynamic-import. But since this can also be fixed from within theNSFWJSpackage, I've decided to explicitly pre-define the import paths instead of resolving them at runtime using variables.package.jsonwith"type": "module"and"type": "commonjs"indist/esmanddist/cjsdirectories respectively to correctly define the scope for both CJS and ESM. This fixes Cannot use import statement outside a module #876.esbuildand import conditionally based on the environment.getGlobalfunction to access the global object in an environment-agnostic way.