-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): win EOL conversion for gen templates #2540
Conversation
I'm surprised that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this solution. I have two small changes requested but conceptually this looks great.
This is probably because we aren't using git to copy these files over, we are essentially using copy and paste on the system. |
Co-authored-by: Joshua Yoes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR gets merged first, looks good!
https://github.com/infinitered/ignite/pull/2540/files/782feb0ebf18cd246c4d703a10c7452a3ae45eae#r1380639904
## [8.10.1](v8.10.0...v8.10.1) (2023-11-03) ### Bug Fixes * **cli:** win EOL conversion for gen templates ([#2540](#2540) by [@frankcalise](https://github.com/frankcalise)) ([ebdc55a](ebdc55a))
🎉 This PR is included in version 8.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
Generators.md
has been updated with changesDescribe your PR
unix2dos
cli utilityTesting
This was manually tested by doing the following:
ignite-cli
project on a Windows machineboilerplate\ignite\templates\**\*.ts*.ejs
files EOL to LF on purpose (likely CRLF after cloning)node bin/ignite new PizzaWin --overwrite --debug --install-deps=false --targetPath="C:\temp\PizzaWin" --git --bundle=com.pizzawin --remove-demo=false --packager=yarn
ignite\templates
has the template files with the CRLF EOLScreenshots
Terminal Warning Upon Failure
Extra Debug Logging