-
Notifications
You must be signed in to change notification settings - Fork 140
Update Ignite Bowser to RN 0.57.3 #103
Changes from 26 commits
297886f
57ebda2
a55a6ac
b64e214
65ef118
034ed7d
d3e2d88
8f123c8
d3c8813
bfe60d8
01c1fb8
fb43b72
ca38d6c
960d572
650b203
3df7d1c
0d1e3de
05cd449
df7537a
9b01d37
5582921
3889325
207b5b5
ed1550d
7d2fd43
d99d3f8
6a10edd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# OSX | ||
# | ||
.idea | ||
.DS_Store | ||
npm-debug.log | ||
npm-debug.log* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,6 @@ async function install (context) { | |
{ template: '.prettierignore', target: '.prettierignore' }, | ||
{ template: '.prettierrc', target: '.prettierrc' }, | ||
{ template: '.solidarity', target: '.solidarity' }, | ||
{ template: 'rn-cli.config.js', target: 'rn-cli.config.js' }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you remove this line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since RN and Babel 7 is handling the ts transpiling this is not needed, since as I understand it the previous rn-cli.config.js was handling the ts transpiling via a npm module. |
||
{ template: 'tsconfig.json', target: 'tsconfig.json' }, | ||
{ template: 'tslint.json', target: 'tslint.json' }, | ||
{ template: 'src/app/main.tsx.ejs', target: 'src/app/main.tsx' } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"presets": ["react-native"], | ||
"presets": ["module:metro-react-native-babel-preset"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👌 |
||
"env": { | ||
"production": { | ||
} | ||
|
@@ -10,6 +10,15 @@ | |
{ | ||
"include": ["NODE_ENV", "API"] | ||
} | ||
], | ||
[ | ||
"@babel/plugin-proposal-decorators", | ||
{ | ||
"legacy": true | ||
} | ||
], | ||
[ | ||
"@babel/plugin-proposal-optional-catch-binding" | ||
] | ||
] | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ export class TextField extends React.Component<TextFieldProps, {}> { | |
style: styleOverride, | ||
inputStyle: inputStyleOverride, | ||
forwardedRef, | ||
...rest, | ||
...rest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you remove the trailing comma? Doesn't linting complain about this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I understand it , trailing comas after rest element is not allowed. I ran ts lint after the ts upgrades and changes and it was ok. |
||
} = this.props | ||
let containerStyle: ViewStyle = { ...CONTAINER, ...PRESETS[preset] } | ||
containerStyle = enhance(containerStyle, styleOverride) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello fellow jetbrains fan. ✋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍