This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Join Redux navigation middleware #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencergazda
reviewed
May 20, 2019
boilerplate/App/Redux/CreateStore.js
Outdated
| @@ -3,6 +3,7 @@ import Config from '../Config/DebugConfig' | |||
| import createSagaMiddleware from 'redux-saga' | |||
| import ScreenTracking from './ScreenTrackingMiddleware' | |||
| import { createReactNavigationReduxMiddleware } from 'react-navigation-redux-helpers' | |||
There was a problem hiding this comment.
You should remove the old createReactNavigationReduxMiddleware import and CI will be OK.
There was a problem hiding this comment.
Thanks! Already done
jamonholmgren
approved these changes
May 21, 2019
infinitered-circleci
pushed a commit
that referenced
this pull request
May 21, 2019
## [4.0.4](v4.0.3...v4.0.4) (2019-05-21) ### Bug Fixes * **navigation:** Fixes Redux navigation middleware being called twice ([#273](#273) by [@superp](https://github.com/superp)) ([2df24ef](2df24ef))
|
🎉 This PR is included in version 4.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with my react-native-camera (black screen after changing tabs) and deeper investigation on it was resolved with joining redux navigation middleware to one initialization.
react-navigation/redux-helpers#53
moaazsidat/react-native-qrcode-scanner#177