Fix rake tests on OS X #10
Conversation
| _READLINK = find_executable('readlink') | ||
| _GREADLINK = find_executable('greadlink') | ||
| READLINK = _GREADLINK.nil? ? _READLINK : _GREADLINK | ||
| PS4 = %Q{#{PREFIX}$(#{READLINK} -f ${BASH_SOURCE[0]})/${LINENO}: } |
There was a problem hiding this comment.
- I'm not a big fan of including
mkmfhere - it's supposed to be used in Makefile scripts and the like but not in "normal" Ruby code. If you look here, you can see it defines a lot of top-level stuff and monkey-patches core types likeString. - Why would you use
greadlink? Isn'treadlinkavailable on OS X? - Doesn't bash find the path to
readlinkif you simply doPS4 = %Q{#{PREFIX}$(readlink -f ${BASH_SOURCE[0]})/${LINENO}: }? - If not, does it work using something like
READLINK = IO.popen("whereis -b readlink").read.match(/\Areadlink:\s([^\s]+)/).captures.first? I know it's kinda ugly and I'm sure there is a better way to do that but you get the idea.
There was a problem hiding this comment.
Yeah, the readlink compatibility fiasco is a little annoying :/. Basically, the version of readlink shipped on OS X is not useful at all - the GNU version always prints the absolute path to the file, the BSD version prints the absolute path to the file only if the file was a symlink. It also doesn't have an option to follow symlinks.
Its possible to install the GNU version of coreutils on OS X, which I understand that most developers do, because the BSD equivalents are very lacking. They're all prefixed with a "g". Hence the reason why we'd find greadlinkfirst and then find readlink.
That said, after having read about mkmf and friends, I've decided to remove the readlink solution and replaced it with something that's a little slower than readlink but should work in our case -$(cd $(dirname ${BASH_SOURCE[0]}); pwd)/$(basename ${BASH_SOURCE[0]}). It won't follow symlinks, but it does get you the absolute path.
|
Just wanted to add that this is great work @smspillaz and I don't mean to scare you away with my comments 😝. I'm just trying to do cross-compatibility properly... |
|
No problem, I haven't really written any ruby code before in any serious
|
BASH_SOURCE isn't always guaranteed to give an absolute path, so use readlink to ensure that we get the absolute path to the source file.
Calling it on its own means that file descriptors don't get passed to it.
find -executable is only available on GNU. find -perm -111 finds all executable files by their mode (although it won't find executable files in access control lists on Linux, which isn't a problem in this case)
|
Good stuff! 👍 |
There are some platform-related differences on OS X which cause bashcov not to work correctly, relating to differences between BASH_SOURCE, fd-passing and find.
Fixes #8