Fixes issue with combining inferno-mobx observer with animations #1587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue
The
track
method of the MobX reaction in observers can be called afterdispose
is called on it.The issue has a number of requirements to occur that would make it rare;
componentWillUnmount
which disposes of the reaction.Then queue forceUpdate can then result in a call to
render
which callstrack
.The solution implemented restores the original
render
method of the component that does not calltrack
when the reaction is disposed.