Select VNode - add support selectedIndex property #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am working on unit tests |
anthony-redFox
force-pushed
the
master
branch
from
595dfa7
to
0a31eb8
Compare
|
Done! |
|
@Havunen Please, take a look |
Havunen
reviewed
Dec 12, 2018
|
|
||
| it('Should strict render select if value set', () => { | ||
| render( | ||
| <select selectedIndex={3} value={'3'}> |
There was a problem hiding this comment.
What about a case where selectedIndex is different than value? Who wins?
There was a problem hiding this comment.
can you add test case with expected result so its thought use case then
|
Did you check if selectedIndex need to be added to typings? |
Havunen
requested changes
Dec 18, 2018
|
Lets merge this @anthony-redFox , Thanks for PR! I will do some testing and small cleaning! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR please:
npm run buildand check that the build succeeds.PR Template
Objective
This PR...
Closes Issue
It closes Issue #...