Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linkEvent return undefined instead of null #1312

Closed
wants to merge 1 commit into from

Conversation

as-com
Copy link
Contributor

@as-com as-com commented Mar 22, 2018

Fixes #1310

This time the branch is correct. 😄

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 95.807% when pulling 0d2f9d8 on as-com:fix-1310 into 24f97a3 on infernojs:dev.

@Havunen
Copy link
Member

Havunen commented Mar 22, 2018

I dont know if returning undefined is good thing, generally we want to avoid those because v8 dont like them. Also adding null value to event listener should be allowed that way you can clear the listener fe: having boolean condition and then return null if you want to remove it.

@as-com
Copy link
Contributor Author

as-com commented Mar 22, 2018

Closing in favor of #1313

@as-com as-com closed this Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants