-
-
Notifications
You must be signed in to change notification settings - Fork 633
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed error when hydrating forwardRef component Github #1486
- Loading branch information
Showing
3 changed files
with
150 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
packages/inferno-hydrate/__tests__/hydrate-forward-ref.spec.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| import { Component, createRef, forwardRef, render } from 'inferno'; | ||
| import { hydrate } from 'inferno-hydrate'; | ||
|
|
||
| describe('Hydrate - Forward Ref', () => { | ||
| let container; | ||
|
|
||
| beforeEach(function() { | ||
| container = document.createElement('div'); | ||
| document.body.appendChild(container); | ||
| }); | ||
|
|
||
| afterEach(function() { | ||
| render(null, container); | ||
| container.innerHTML = ''; | ||
| document.body.removeChild(container); | ||
| }); | ||
|
|
||
| it('Should be possible to forward createRef', () => { | ||
| const FancyButton = forwardRef((props, ref) => ( | ||
| <button ref={ref} className="FancyButton"> | ||
| {props.children} | ||
| </button> | ||
| )); | ||
|
|
||
| expect(FancyButton.render).toBeDefined(); | ||
|
|
||
| class Hello extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
|
|
||
| // You can now get a ref directly to the DOM button: | ||
| this.btn = createRef(); | ||
| } | ||
|
|
||
| componentDidMount() { | ||
| expect(this.btn.current).toBe(container.querySelector('button')); | ||
| } | ||
| render() { | ||
| return <FancyButton ref={this.btn}>Click me!</FancyButton>; | ||
| } | ||
| } | ||
|
|
||
| container.innerHTML = '<button class="FancyButton">Click me!</button>'; | ||
|
|
||
| hydrate(<Hello />, container); | ||
|
|
||
| expect(container.innerHTML).toBe('<button class="FancyButton">Click me!</button>'); | ||
| }); | ||
|
|
||
| it('Should be possible to forward callback ref', () => { | ||
| const FancyButton = forwardRef((props, ref) => ( | ||
| <button ref={ref} className="FancyButton"> | ||
| {props.children} | ||
| </button> | ||
| )); | ||
|
|
||
| expect(FancyButton.render).toBeDefined(); | ||
|
|
||
| class Hello extends Component { | ||
| render() { | ||
| return ( | ||
| <FancyButton | ||
| ref={btn => { | ||
| if (btn) { | ||
| expect(btn).toBe(container.querySelector('button')); | ||
| } | ||
| }} | ||
| > | ||
| Click me! | ||
| </FancyButton> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| container.innerHTML = '<button class="FancyButton">Click me!</button>'; | ||
|
|
||
| hydrate(<Hello />, container); | ||
|
|
||
| expect(container.innerHTML).toBe('<button class="FancyButton">Click me!</button>'); | ||
|
|
||
| render(null, container); | ||
|
|
||
| expect(container.innerHTML).toBe(''); | ||
| }); | ||
|
|
||
| it('Should be possible to patch forwardRef component', () => { | ||
| const FancyButton = forwardRef((props, ref) => { | ||
| return ( | ||
| <button ref={ref} className="FancyButton"> | ||
| {props.children} | ||
| </button> | ||
| ); | ||
| }); | ||
|
|
||
| expect(FancyButton.render).toBeDefined(); | ||
|
|
||
| let firstVal = null; | ||
|
|
||
| container.innerHTML = '<button class="FancyButton">Click me!</button>'; | ||
|
|
||
| hydrate( | ||
| <FancyButton | ||
| ref={btn => { | ||
| firstVal = btn; | ||
| }} | ||
| > | ||
| Click me! | ||
| </FancyButton>, | ||
| container | ||
| ); | ||
|
|
||
| expect(container.innerHTML).toBe('<button class="FancyButton">Click me!</button>'); | ||
| expect(firstVal).not.toBe(null); | ||
|
|
||
| let secondVal = null; | ||
|
|
||
| render( | ||
| <FancyButton | ||
| ref={btn => { | ||
| secondVal = btn; | ||
| }} | ||
| > | ||
| Click me! 222 | ||
| </FancyButton>, | ||
| container | ||
| ); | ||
|
|
||
| expect(firstVal).toBe(null); | ||
| expect(secondVal).not.toBe(null); | ||
|
|
||
| expect(container.innerHTML).toBe('<button class="FancyButton">Click me! 222</button>'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters