FI-2325: Check fhirContext #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
reviewed
Dec 4, 2023
| it 'fails if fhirContext is not an Array' | ||
| it 'passes if fhirContext valid' do | ||
| numericalElement = 123 | ||
| body = valid_body.merge(fhirContext: ["Organization/123", "DiagnosticReport/123"]) |
There was a problem hiding this comment.
Could you include a version-specific reference here as well?
Jammjammjamm
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fhirContext is optional in SMART app launch, but we still want to validate its format when it is present. This PR adds a validation function in the smart_token_response_body test to validate the fhirContext if it is present.
Testing Guidance
spec tests for the fhirContext tests have been added and they can be ran to test this PR by running
bundle exec rspec spec/smart_app_launch/token_response_body_test_spec.rband making sure all the tests pass. Can also run Inferno locally and test in browser to make sure fhirContext tests work as expected.