Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-1223: Expose multiple software versions at /version endpoint #62

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Jul 5, 2023

Summary

Updates the /version endpoint to return a JSON containing the version numbers of both this wrapper as well as the version of the HL7 validator. Previously this was just text of the wrapper version number.
Sample result:

{"org.hl7.fhir.validation":"5.6.93","inferno-framework/fhir-validator-wrapper":"2.2.1"}

This PR replaces #42 mostly because that one was kind of a mess in terms of branch structure, but also it created a new route, and it called the wrong function to get a version number so it didn't actually return the right number for the HL7 validator.

In a few places I refer to this as "JSON containing the version numbers of software" so we could add more at some point if we want to and we don't have to rename/change docs again/etc. Though I don't have any reason to expect we'll actually need to do that.

Testing Guidance

Run the app and confirm a GET /version returns a JSON both software versions

Note there are two other changes associated with this where other tools read the version string:

@dehall dehall force-pushed the expose-validator-version-redux branch from 04ec2b5 to e6b06b5 Compare July 24, 2023 20:11
@dehall dehall merged commit 74ccd94 into master Jul 24, 2023
@dehall dehall deleted the expose-validator-version-redux branch July 24, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants