Controller#propfind: Handle the empty request body case.

Per RFC 2518 §8.1: An empty PROPFIND request body must be treated as a request for the names and values of all properties. Signed-off-by: Alex Zepeda <[email protected]>
inferiorhumanorgans · Aug 26, 2013 · 14502d2 · 14502d2
1 parent ab3404c
commit 14502d2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/dav4rack/controller.rb b/lib/dav4rack/controller.rb
@@ -171,7 +171,9 @@ def propfind
       unless(resource.exist?)
         NotFound
       else
-        unless(request_document.xpath("//#{ns}propfind/#{ns}allprop").empty?)
+        # Per RFC 2518 §8.1
+        # An empty PROPFIND request body must be treated as a request for the names and values of all properties.
+        if !request_document.xpath("//#{ns}propfind/#{ns}allprop").empty? or (request.content_length == '0')
           properties = resource.properties
         else
           properties = (
@@ -187,8 +189,9 @@ def propfind
 
             to_element_hash(item)
           }
+
+          # We shouldn't ever be here.
           raise BadRequest if properties.empty?
-          properties = resource.properties if properties.empty?
         end
         multistatus do |xml|
           find_resources.each do |resource|