Allow newer thecodingmachine/safe #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are all these changes necessary? I mean wouldnt #1651 suffice? |
|
@ricardoboss If your minimal update does the trick, I'm in favour of it. However, I had some phpstan warnings to fix locally (might be just my machine, though). |
|
I noticed you requested to merge into the base branch, whereas my request is for the PHP 8 feature branch (it wouldn't be an immediate update, but it would update |
|
should be ready now 💚 |
maks-rafalko
approved these changes
Feb 2, 2022
sanmai
approved these changes
Feb 3, 2022
|
@mmoll I'd appreciate if you don't force-push. Makes reviewing new changes a lot harder 😢 |
sanmai
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thecodingmachine/safe#322 was needed for the phpstan check to pass.