Skip to content

Commit

Permalink
google#2130 - Stop skipping certain tests under Windows
Browse files Browse the repository at this point in the history
While on local machine the test cases took roughly similar times both on Windows and on Unix, on GitHub CI the tests under Windows took more than 1 hour (!). Keeping two test cases excluded that were previously measured to be slow.
  • Loading branch information
ineuwirth committed Jun 17, 2023
1 parent a316d3e commit c11c24d
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,9 @@ public void run() {
*/

public void testFutureBash() {
if (isWindows()) {
return; // TODO: b/136041958 - Running very slowly on Windows.
}
final CyclicBarrier barrier =
new CyclicBarrier(
6 // for the setter threads
Expand Down Expand Up @@ -618,6 +621,9 @@ public void run() {

// setFuture and cancel() interact in more complicated ways than the other setters.
public void testSetFutureCancelBash() {
if (isWindows()) {
return; // TODO: b/136041958 - Running very slowly on Windows.
}
final int size = 50;
final CyclicBarrier barrier =
new CyclicBarrier(
Expand Down Expand Up @@ -1326,4 +1332,8 @@ protected void interruptTask() {
interruptTaskWasCalled = true;
}
}

private static boolean isWindows() {
return OS_NAME.value().startsWith("Windows");
}
}

0 comments on commit c11c24d

Please sign in to comment.