feat: support deep partial props updates #1247
Conversation
HTML already prevents this by default, no need for custom logic after all
* add global visit options hook
Scroll position can fail to update in Firefox when setting it via `element.scrollTop` and `element.scrollLeft`. Change to preferring `element.scrollTo` with a fallback for the previous method to ensure backwards compatibility. Resolves inertiajs#1079
Update axios version
Co-authored-by: Robert Boes <[email protected]>
Co-authored-by: Robert Boes <[email protected]>
Co-authored-by: Robert Boes <[email protected]>
Doing a reload and sending across `undefined` explicitly for a key in data works, it will remove it from the url.
But the type doesn't allow it
E.g. the following works in straight js
```js
// page is /hello
Inertia.reload({data: {test: 5}});
//page is now /hello?test=5
Inertia.reload({data: {test: null}});
//page is now /hello?test=
Inertia.reload({data: {test: undefined}});
//page is now /hello
```
Allow React 18 as a peer dependency
Bump Axios to ^0.27.0
Add `undefined` as a valid option FormDataConvertable
Change to preferring element.scrollTo
|
This would be awesome. Exactly what I was talking about here: #1249 |
|
@reinink Why would you Force push on master on a popular repo? You obliterated all the open PRs |
|
Hey! Thanks so much for your interest in Inertia.js and for submitting this contribution. In an attempt to get on top of the issues and pull requests on this project I am going through all the older issues and PRs and closing them, as there's a decent chance that they have since been resolved or are simply not relevant any longer. My hope is that with a "clean slate" me and the other project maintainers will be able to better keep on top of issues and PRs moving forward. Of course there's a chance that this PR is still relevant, and if that's the case feel free to re-submit it. If it's a new feature and not a bug fix maybe respond here first to make sure that it's something we want to include in the library. Really not trying to be dismissive here, I just need to find a way to get this project back into a state that I am able to maintain it. Hope that makes sense! ❤️ |
This basically does a deep merge of the
onlyprops that have been requested using the dot notation (egfoo.baz) into the current props, instead of the current shallow mergeGoes by par with inertiajs/inertia-laravel#435