make_cffi.py incorrectly finds compiler

[Arfrever]

make_cffi.py incorrectly finds compiler:

• It does not call customize_compiler() function, which would make code respect user-set CC environmental variable.
• It uses compiler.executables["compiler"], which is only a class-default non-customized value. compiler.compiler should be called instead.

Compare:

$ CC="x86_64-pc-linux-gnu-gcc" python -c 'import distutils.ccompiler; compiler = distutils.ccompiler.new_compiler(); print(compiler.executables["compiler"])'
['cc']
$ CC="x86_64-pc-linux-gnu-gcc" python -c 'import distutils.ccompiler; compiler = distutils.ccompiler.new_compiler(); distutils.sysconfig.customize_compiler(compiler); print(compiler.compiler)'
['x86_64-pc-linux-gnu-gcc']

Patch: make_cffi.patch.txt

[indygreg]

Good find! I'll commit this patch shortly. Thank you!

[Arfrever]

You have not applied the last part of patch, so CC variable is still ignored.
This is still needed:

--- a/make_cffi.py
+++ b/make_cffi.py
@@ -84,7 +84,7 @@
 # Distutils doesn't set compiler.preprocessor, so invoke the preprocessor
 # manually.
 if compiler.compiler_type == "unix":
-    args = list(compiler.executables["compiler"])
+    args = compiler.compiler
     args.extend(
         ["-E", "-DZSTD_STATIC_LINKING_ONLY", "-DZDICT_STATIC_LINKING_ONLY",]
     )

compiler.compiler, compiler.compiler_so, compiler.linker_exe, compiler.linker_so etc. attributes are already lists.