ruff: disable rule RUF052 #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pylint failure is quite exciting. No idea what that's about.. From what I can tell, it's due to conda switching to |
|
I'm not super happy with RUF052 as it is: astral-sh/ruff#14796. Let's see what happens. |
Yeah, agreed. It feels very weird to apply that rule to function/method arguments. |
|
The pylint failure seems to be this: pylint-dev/pylint#10000 (comment) |
|
I'll go ahead and close this, since hopefully it'll just fix itself in the next week or so 😁 |
|
They've fixed RUF052, and there's a release with the fix! https://github.com/astral-sh/ruff/releases/tag/0.8.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUF052 seems to complain about underscore variables in function arguments. We use that quite a bit to denote "useful, but private, don't depend on this" arguments, so it seemed like a good idea to disable it.