Enable force_device_scalars by default
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
majosm
force-pushed
the
force-device-scalars-by-default
branch
from
0257761
to
8b33f2d
Compare
inducer
force-pushed
the
force-device-scalars-by-default
branch
from
8b33f2d
to
edf580b
Compare
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instances of
PyOpenCLArrayContextthat don't explicitly passforce_device_scalars=Truewill have it set toFalse. This is deprecated, and will be an error once inducer/arraycontext#278 goes in.After the arraycontext PR gets merged I'll submit a follow-up here that makes the interface for
force_device_scalarsmatch (i.e., allow it to beNone), so that it will only emit deprecation warnings when explicitly specified.