-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple volumes in a discretization collection #236
Conversation
752aa81
to
b678028
Compare
@majosm I think this is headed towards being not totally broken. Could you take a look to see how things look to you and look into the remaining issues above? |
The changes discussed in inducer/meshmode#308 (comment) are now in. Ready to take a look, @majosm. (assuming CI is happy 🤞) |
@inducer Any particular reason to be using def func(..., volume_dd=None):
if volume_dd is None:
volume_dd = DD_VOLUME_ALL
... vs. def func(..., volume_dd=DD_VOLUME_ALL)? ? I don't remember the exact guidelines for this. (I guess mutable objects should use the first form... not sure what else.) Does it make a difference here? |
I agree that mutable objects should use the first form. The other aspect that I run into is that if there's multiple layers of functions calling each other, and only the "innermost" function looks at the argument, then I find it cleaner to use |
This isn't finished yet. Missing:
*inter_volume_trace_pairs
flat_size_and_dtype
arraycontext#150requirements.txt
back at meshmodemain
cc @majosm
Closes #104.