make text props required for buttons

ref learningequality#168
indirectlylit · Feb 23, 2021 · 8c1a061 · 8c1a061
1 parent 40b6a04
commit 8c1a061
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/pages/buttons.vue b/docs/pages/buttons.vue
@@ -132,7 +132,7 @@
         Be sure to consider internationalization, translation, and cultural meaning in the use of icon buttons.
       </p>
       <p>
-        Always include a tooltip with the name of the action for icon buttons.
+        A tooltip with the name of the action is required for an icon button.
       </p>
       <DocsShow>
         <KButtonGroup>

diff --git a/lib/buttons-and-links/KIconButton.vue b/lib/buttons-and-links/KIconButton.vue
@@ -7,6 +7,7 @@
     :appearanceOverrides="appearanceOverrides"
     :buttonType="buttonType"
     :aria-label="ariaLabel"
+    text=""
     v-on="$listeners"
   >
     <UiTooltip
@@ -63,7 +64,7 @@
       },
       tooltip: {
         type: String,
-        default: null,
+        required: true,
       },
     },
     computed: {

diff --git a/lib/buttons-and-links/buttonMixin.js b/lib/buttons-and-links/buttonMixin.js
@@ -18,7 +18,7 @@ export default {
      */
     text: {
       type: String,
-      required: false,
+      default: null,
     },
     /**
      * Button appearance: 'raised-button', 'flat-button', or 'basic-link'