Upgrade CheapoDC driver for new device firmware features #2142
Conversation
Includes new ability to snoop weather station device. Add humidity to Weather Simulator to allow for dew point calculation.
|
I noticed the CheapoDC listing on indilib.org went missing during the website migration so resubmitted. |
@naheedsa Please check |
|
Sorry another question. Looking at the suggested simplification of using Property.load(). There is a call to loadConfig(); in CheapoDC::updateProperties(). I assume the best thing would be to not do any calls to Property.load() in CheapoDC::initProperties(). Also move the couple of EnableSnoop... switch checks to after the loadConfig(); Assuming this would be more correct. Some of what happens when copying other drivers. |
|
Made the requested simplification changes plus moved the loads to updateProperties. |
|
Also saw that my driver submission on indilib.org was accepted. I must have done something wrong when submitting the description HTML because it is not rendering properly. |
|
Property.load does NOT call ISNewXXX if that's what you mean, it simply initializes the property values. |
drivers/auxiliary/cheapodc.h
Outdated
| char locationDevice[MAXINDIDEVICE] = {"Telescope Simulator"}; | ||
| char locationProperty[MAXINDINAME] = {"GEOGRAPHIC_COORD"}; | ||
| char locationLatAttribute[MAXINDINAME] = {"LAT"}; | ||
| char locationLongAttribute[MAXINDINAME] = {"LONG"}; | ||
| char temperatureDevice[MAXINDIDEVICE] = {"Focuser Simulator"}; | ||
| char temperatureProperty[MAXINDINAME] = {"FOCUS_TEMPERATURE"}; | ||
| char temperatureAttribute[MAXINDINAME] = {"TEMPERATURE"}; |
There was a problem hiding this comment.
What do you need these for? GEOGRAPHIC_COORD and FOCUS_TEMPERATURE are both standard INDI properties. If you want to snoop other devices, you need to have a single property ActiveDeviceTP for all the different types of devices you need to snoop.
If you check the example above, you'll see how INDI::CCD snoops the properties from other devices.
There was a problem hiding this comment.
Looking back likely not understanding how ActiveDeviceTP works. I will look at it.
Thanks Jasem.
There was a problem hiding this comment.
Looking at INDI:CCD, I see that it uses IUGetConfigText to fill the intial text for the ActiveDeviceTP property with any values that may be found in the config file. This is similar to what I intended above. Moving to using only Property.load(); removes this function. Is there a better or preferred way to do this?
There was a problem hiding this comment.
You're right, this code is outdated and need to be removed.
There was a problem hiding this comment.
Updated to using ActiveDeviceTP property.
Will update the driver listing on indilib.org on Monday.
CheapoDC driver release to add support for firmware 2.x features
- bug fix for Longitude range checking (actually a firmware bug).
- adds support for Weather Device snoop for local temperature/humidity instead of using CheapoDC weather query
- move Latitude/Longitude settings to more common Site Management Tab with Location settings
- Location Snoop enabled by default for Telescope Simulator
- maintain backwards compatibility with previous firmware version
Weather Simulator
- added Humidity as a weather value so that dew point may be calculated by snooping devices. (ie: CheapoDC)