Fix build bug on Windows #1917
Merged
Fix build bug on Windows #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks, that works! Do you have any ideas if the failure in the Visual Studio is similar? |
|
@knro I looked at the error logs of the build and found that most of them were due to calling proprietary libraries on the Linux platform on the Windows platform, which resulted in errors. Maybe we need to differentiate the platform through macros and rewrite some codes. |
knro
pushed a commit
that referenced
this pull request
Aug 2, 2023
knro
pushed a commit
to knro/indi
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fix building bug on Windows platform.I hava tested on Msys2(Mingw64)