Bump Minimum Version Requirements and Initialize Variables #108
Conversation
| @@ -254,12 +254,12 @@ public static function user_url( $me ) { | |||
| */ | |||
| public static function post_handler( $user_id ) { | |||
| $status = 200; | |||
| $action = static::$input['action']; | |||
| $url = static::$input['url']; | |||
| $action = isset( static::$input['action'] ) ? static::$input['action'] : 'create'; | |||
There was a problem hiding this comment.
we have so many of these, i wonder if we should start using something like the get() helper here: http://heap.ch/blog/2015/12/19/php-default-values/#convenience . not necessary for this PR, just an idea. thoughts?
There was a problem hiding this comment.
I have a similar function I created in most of my plugins called ifset that looks pretty much the same.
There was a problem hiding this comment.
ah, nice i'm all for adding it here and using it everywhere! (and i like get better than isset, since it returns a value and not a boolean...but that's a bikeshed. :P)
also, ooh, php 7 added an ?? operator for this! https://wiki.php.net/rfc/isset_ternary . nice to know.
There was a problem hiding this comment.
WordPress will hopefully get there before I retire.
This should address #105 and #97 in regards to the initialization of variables and ensuring that the WordPress features in the plugin align with the minimum version they were implemented in.