Add left margin to timeline and fix colors in edit mode #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
renefs
commented
Dec 12, 2024
renefs
commented
- Fix the timeline width in edit mode to avoid participant names to overlap the calendar.
- Display the green background and the green border only in the editable area of the timeline, not in the participant availability area.
|
I'd add some left padding/margin to the participant avatars when the screen is in tablet layout, otherwise it looks good :)
|
renefs
force-pushed
the
fix-timeline-styles
branch
from
04b9a7b to
a09c577
Compare
tomasr8
reviewed
Dec 12, 2024
newdle/client/src/components/creation/timeslots/Timeline.module.scss
Outdated
Show resolved
Hide resolved
renefs
force-pushed
the
fix-timeline-styles
branch
3 times, most recently
from
f94b306 to
96398d4
Compare
Display placeholder only in the green timeline Display participants if not in edit mode
renefs
force-pushed
the
fix-timeline-styles
branch
from
96398d4 to
6dadb6d
Compare
tomasr8
approved these changes
Dec 13, 2024
|
@ThiefMaster do you think we could merge this? I don't want to keep the ugly overflow in prod for longer than needed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.