Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyncronous wait for paypal confirmation and added the custom pay… #232

Closed
wants to merge 0 commits into from

Conversation

rabser
Copy link

@rabser rabser commented Jun 6, 2024

Added the paypal fees to be paid by participants, so the effective costs of the conference are not substracted by paypal commission (configurable). Also it's better managed the asynchronous confirmation from paypal IPN and now the return page for the merchant it's showed always as paid.

Copy link
Member

@duartegalvao duartegalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution! there are a few code style issues, I've left my suggestions here

payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/plugin.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/plugin.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/util.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/plugin.py Outdated Show resolved Hide resolved
Copy link
Member

@duartegalvao duartegalvao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more suggestions.. also feel free to mark as resolved the comments which you have addressed, makes it easier to keep track of things 😄

EDIT: also, please check the linting errors in the CI, I have just enabled it

payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/controllers.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/plugin.py Outdated Show resolved Hide resolved
payment_paypal/indico_payment_paypal/util.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants