Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable use with webpack by removing unnecessary fs call #252

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

1R053
Copy link
Contributor

@1R053 1R053 commented Jan 29, 2017

to fix #130 this pull request takes the code from an old but forgotten branch d501e7b

Copy link
Contributor

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds legit

@smartin015
Copy link

Could this get checked in please? I'm running into the same bug.

@mhamann mhamann merged commit 5e8a34d into indexzero:master Aug 16, 2017
@brandones
Copy link

When's the next release planned for? I need this.

@mhamann
Copy link
Collaborator

mhamann commented Oct 14, 2017

This is already released in v0.8.5

@dkent600
Copy link

I'm using v0.10.0 and the problem still exists.

"TypeError: existsSync is not a function"

@mhamann
Copy link
Collaborator

mhamann commented Jan 16, 2018

I think this is occurring due to some dependencies required by yargs. In v1.0, we'll upgrade to the latest version, which may help.

@catamphetamine
Copy link

catamphetamine commented Mar 17, 2021

I think this is occurring due to some dependencies required by yargs. In v1.0, we'll upgrade to the latest version, which may help.

This does look like an issue in yargs

Can't import the named export 'dirname' from non EcmaScript module (only default export is available)
...
 @ c:/dev/JITU/node_modules/yargs/build/index.cjs
 @ c:/dev/JITU/node_modules/yargs/index.cjs
 @ c:/dev/JITU/node_modules/nconf/lib/nconf/stores/argv.js
 @ c:/dev/JITU/node_modules/nconf/lib/nconf/stores sync ^\.\/.*$
 @ c:/dev/JITU/node_modules/nconf/lib/nconf.js
 @ c:/dev/JITU/node_modules/node-zendesk/lib/client.js
 @ c:/dev/JITU/lib/zendesk.js

Update: Updated Webpack from 4 to 5 and the error disappeared.

@catamphetamine

This comment has been minimized.

@catamphetamine

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support using nconf in a (browserify-based) browser context
8 participants